Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: PS3, Line 3257: ASSERT_OK(FindTabletLeader(tablet_servers_, tablet_id, kTimeout, &leader_tsd)); Why not to move this under the loop scope so it would be the first operation of it? Doing so, it might be possible to get rid of the later of FindTabletLeader(). Also, if not doing so, how to make sure that the actual leader TS hasn't changed on the second iteration after the tserver with the initial leader was restarted? -- To view, visit http://gerrit.cloudera.org:8080/8107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeaf99ce57f7d5cd01a6c786c178567a98438ced Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
