Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consensus/consensus_meta.cc File src/kudu/consensus/consensus_meta.cc: Line 276: if (PREDICT_FALSE(FLAGS_cmeta_inject_latency_on_flush_ms > 0)) { > you may need to ANNOTATE_UNPROTECTED_READ this here and below Sure. That's because this flag can be modified at runtime? http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS3, Line 125: be allowed at a time > it doesn't actually serialize the whole election, right? it just serializes Sure, I'll reword this. As a side note, one of the things I dislike about how we treat test-only hidden gflags is that for some reason we still bother to provide descriptions for them, even though they're totally unnecessary. -- To view, visit http://gerrit.cloudera.org:8080/8107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeaf99ce57f7d5cd01a6c786c178567a98438ced Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
