David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs ......................................................................
Patch Set 12: I like the changes in general (post specific comments in a few mins). One concern that I have in general though, is that we need to make sure that once we abort one transaction, no other changes to the tablet can be made visible. Note that I'm not saying that this is not addressed here on in follow up patches, just that I want to make sure it is. What I mean is that if we get an error and abort a txn that was already applying, then no other applying transaction can be made visible, otherwise we might break isolation/consistency guarantees. In practice, since we're deleting the tablet data or otherwise not allowing it to be scanned I don't think it matters too much what actually gets to apply or not (i.e. I don't care too much about stopping applying transactions), but scanners should immediately be prevented from starting or continuing and copies should be prevented. Is this taken care of? -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
