Todd Lipcon has posted comments on this change.

Change subject: Allow tablet shutdown without completing txs
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7439/11//COMMIT_MSG
Commit Message:

Line 21: Testing is done by adding the following:
> forgot to ask: does TestDeleteTableWithConcurrentWrites in delete_table-ite
sorry for the email flood, but a couple more test suggestions:

- TestDeleteTableWithConcurrentWrites focuses on complete deletion of a table 
during a write workload, and expects the writes to start getting a NotFound 
error since the table is gone.
- We should add another which shuts down (eg by injecting a failure) just a 
single replica of a repl=3 table and ensures that the client does _not_ see any 
errors. ie it should see the "Aborted" errors and transparently fail over to 
another replica. It should then restart the server so that the tablet is 
available again and make sure that it can recover properly. Hopefully this test 
should be randomized enough to sometimes pick a leader, sometimes a follower.


-- 
To view, visit http://gerrit.cloudera.org:8080/7439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to