Andrew Wong has posted comments on this change. Change subject: Allow tablet shutdown without completing txs ......................................................................
Patch Set 12: Right, that's definitely a valid concern: on-disk isn't the only place we can "persist" the data. Right now, the only time we'd ever get in this "aborting transactions without them committing" state is when we're shutting down the replica, so we should be safe in this patch. That said, a fact of life is that we'll need to synchronize the tablet's new state and the replica. Yes, there is a slight change in this patch at TabletReplica to do this at shutdown, but when it comes time to do this at disk-failure-time, this will need to be taken care of. One way to do that would be to change the replica's state synchronously (e.g. to SHUTDOWN_PENDING, HANDLING_FAILURE, or somesuch), and then synchronously shut down the tablet's MVCC manager. In doing so, the replica _should_ stop responding to scan requests and copy requests. Work for another patch though. This one has roughly what I described: https://gerrit.cloudera.org/#/c/7442/ -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
