David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs ......................................................................
Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: Line 98: if (shutdown_pending_.Load()) { use PREDICT_FALSE PS12, Line 99: VLOG(1) use LOG_EVERY_N or even just LOG, this is an important message that is not too common http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: PS12, Line 275: shutdown_pending_.Store(true); we now have std::atomic http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: PS12, Line 796: CHECK(mvcc_.IsShuttingDown()) << "MVCC must be shut down to survive transaction failures"; not sure I like how we're using the mvcc manager as a mediator here. seems messy. lemme think of an alternative -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
