Alexey Serbin has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: PS3, Line 786: : // Note: the lock is only ever acquired via try_lock(); if it cannot be > Yes. I think the cleanest way to do that is to modify the failure detector OK, I see. Thank you for the clarification! http://gerrit.cloudera.org:8080/#/c/8107/4/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 3244: // Drive up the number of elections by reducing the failure period. > Disabling pre-elections also cuts the number of elections (and thus votes) SGTM. Line 3245: "--raft_heartbeat_interval_ms=100" > I don't think it's strictly necessary. 300 ms to detect a failure is reason Yep, anyway 300 < 5000, so it's good enough, I agree. -- To view, visit http://gerrit.cloudera.org:8080/8107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeaf99ce57f7d5cd01a6c786c178567a98438ced Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
