Adar Dembo has posted comments on this change. Change subject: KUDU-2149: avoid election stacking by restoring failure monitor semantics ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8107/3/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: PS3, Line 3257: ASSERT_OK(FindTabletLeader(tablet_servers_, tablet_id, kTimeout, &leader_tsd)); > Why not to move this under the loop scope so it would be the first operatio I can move it into the start of the loop to replace the call at the end of the loop, but then I'll still need to add a call after the loop ends, in order to measure the vote count after the second test. That's because FindTabletLeader() isn't just used to find the leader, but also to wait for a leader to be voted into existence. I don't follow your second point. The FindTabletLeader() call at the end of the loop writes to leader_tsd, so when we loop, leader_ts will be updated and should reflect the leader post-restart, no? -- To view, visit http://gerrit.cloudera.org:8080/8107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifeaf99ce57f7d5cd01a6c786c178567a98438ced Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
