Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: mvcc: allow tablet shutdown without completing txs ...................................................................... Patch Set 15: (6 comments) http://gerrit.cloudera.org:8080/#/c/7439/14/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/7439/14/src/kudu/integration-tests/ts_tablet_manager-itest.cc@40 PS14, Line 40: #include "kudu/gutil/strings/substitute.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.h@275 PS12, Line 275: / Once called, new transactions > we now have std::atomic Done http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.cc@98 PS12, Line 98: if (PREDICT_FALSE(shutdown_pending_.load())) { > use PREDICT_FALSE Done http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.cc@99 PS12, Line 99: LOG(WAR > use LOG_EVERY_N or even just LOG, this is an important message that is not Done http://gerrit.cloudera.org:8080/#/c/7439/14/src/kudu/tablet/transactions/transaction_driver.h File src/kudu/tablet/transactions/transaction_driver.h: http://gerrit.cloudera.org:8080/#/c/7439/14/src/kudu/tablet/transactions/transaction_driver.h@237 PS14, Line 237: Status Init(gscoped_ptr<Transaction> transaction, > warning: function 'kudu::tablet::TransactionDriver::Init' has a definition Done http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/transactions/transaction_driver.cc@68 PS12, Line 68: using std::string; > warning: using decl 'shared_ptr' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:07:01 +0000 Gerrit-HasComments: Yes
