David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: mvcc: allow tablet shutdown without completing txs ...................................................................... Patch Set 15: This is one of the most tricky changes (if not the most tricky) in the whole patch series, IMO. I would like to see this new failure mode sprinkled over other integration tests that actually stress consensus and transactions so that we're confident things are have not been broken. exactly_once_writes-itest, raft_consensus-itest, linked_list-test come to mind but there might be other/better candidates It might be impossible to test this independently. If that is the case I'd be happy to have a test-only patch in the sequence (as close as possible to this one) where we exercise the complete failure mode and that includes several different dist-test runs. -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:50:13 +0000 Gerrit-HasComments: No
