Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8157
to review the following change.
Change subject: subprocess: Call should redirect stdout to stderr when stdout
not requested
......................................................................
subprocess: Call should redirect stdout to stderr when stdout not requested
The upcoming "cluster shell" tool in the Kudu CLI will use stdout/stdin to
communicate with the user. As such, I want to make sure we're not leaking
anything into stdout, which means dealing with undesirable stdout output
generated by Subprocess::Call. That output is still useful in tests though,
so let's redirect it to stderr rather than disable it entirely.
As an alternative, I'm open to disabling stdout/stderr entirely if the
consensus is that this output just isn't interesting.
Change-Id: I9d81dee93817c560c1237114fb515facbdb06b1d
---
M src/kudu/util/subprocess-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
3 files changed, 109 insertions(+), 42 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/8157/1
--
To view, visit http://gerrit.cloudera.org:8080/8157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d81dee93817c560c1237114fb515facbdb06b1d
Gerrit-Change-Number: 8157
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
