Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 )
Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.cc@674 PS2, Line 674: p.RedirectStdoutToStderr(); > this strikes me as odd default behavior,don't you think? I explained the motivation in the commit description. Could you comment on what in particular you disagree with? -- To view, visit http://gerrit.cloudera.org:8080/8157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d81dee93817c560c1237114fb515facbdb06b1d Gerrit-Change-Number: 8157 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 16:26:04 +0000 Gerrit-HasComments: Yes
