Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 )
Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested ...................................................................... Patch Set 3: > Patch Set 2: > > (1 comment) I don't disagree with using it for the purpose you described (ie redirect for the minicluster tool). But given this is generic utility code I'd expect it to have the same semantics as a normal fork+exec by default (i.e pass-through the parent stdout/stderr descriptors to the subprocess). If I read the patch right, it seems like the default if you just use "Subprocess::Call" is now to do the equivalent of "foo 1>&2" which is not what I'd normally expect (eg it doesn't match the python 'subprocess' module or the 'system()' function in libc) -- To view, visit http://gerrit.cloudera.org:8080/8157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d81dee93817c560c1237114fb515facbdb06b1d Gerrit-Change-Number: 8157 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 17:14:32 +0000 Gerrit-HasComments: No
