Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 )
Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.h@68 PS2, Line 68: Is mutually exclusive with stream : // disabling and sharing. > What I'm trying to say is that any particular stream may be disabled (i.e. hrm. Is your minicluster tool using internal minicluster or external? if the latter, wouldn't it suffice to just use the new Call() parameter when you start the daemons? If the former, maybe you just want to have your tool call dup2(STDERR_FILENO, STDOUT_FILENO) to redirect all stderr to stdout? -- To view, visit http://gerrit.cloudera.org:8080/8157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d81dee93817c560c1237114fb515facbdb06b1d Gerrit-Change-Number: 8157 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2017 17:36:13 +0000 Gerrit-HasComments: Yes
