Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 )
Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.h@68 PS2, Line 68: Is mutually exclusive with stream : // disabling and sharing. > hrm. Is your minicluster tool using internal minicluster or external? if th Todd: It's using external, though I aspire for it to use either one day. In any case, I hadn't considered handling redirection within the tool and letting it percolate down from there. I'll do that and revert this policy change. Dan: Moot point now, because I've reverted much of this patch (it's now purely cosmetic). -- To view, visit http://gerrit.cloudera.org:8080/8157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d81dee93817c560c1237114fb515facbdb06b1d Gerrit-Change-Number: 8157 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 29 Sep 2017 19:53:49 +0000 Gerrit-HasComments: Yes
