Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8256
to review the following change.
Change subject: KUDU-2187. Don't hold threadpool lock while creating threads
......................................................................
KUDU-2187. Don't hold threadpool lock while creating threads
This changes the threadpool implementation so that if a task submission
needs to start a thread, it does so after releasing the lock. This
enables other worker threads to continue to process items even if thread
creation is slow.
This is meant to address various cases where I've seen stalled writes
with high 'mutex_wait_us' metrics. Looking at the logs it is sometimes
the case that this correlates with a single slow pthread creation.
Change-Id: If91cb032db25ed539ec8a952f302cf4501b3c240
---
M src/kudu/util/thread.cc
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
4 files changed, 152 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8256/1
--
To view, visit http://gerrit.cloudera.org:8080/8256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If91cb032db25ed539ec8a952f302cf4501b3c240
Gerrit-Change-Number: 8256
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
