Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8256 )
Change subject: KUDU-2187. Don't hold threadpool lock while creating threads ...................................................................... KUDU-2187. Don't hold threadpool lock while creating threads This changes the threadpool implementation so that if a task submission needs to start a thread, it does so after releasing the lock. This enables other worker threads to continue to process items even if thread creation is slow. This is meant to address various cases where I've seen stalled writes with high 'mutex_wait_us' metrics. Looking at the logs it is sometimes the case that this correlates with a single slow pthread creation. Change-Id: If91cb032db25ed539ec8a952f302cf4501b3c240 Reviewed-on: http://gerrit.cloudera.org:8080/8256 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/thread.cc M src/kudu/util/threadpool-test.cc M src/kudu/util/threadpool.cc M src/kudu/util/threadpool.h 4 files changed, 164 insertions(+), 56 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If91cb032db25ed539ec8a952f302cf4501b3c240 Gerrit-Change-Number: 8256 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
