Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8256 )
Change subject: KUDU-2187. Don't hold threadpool lock while creating threads ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/8256/1/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/8256/1/src/kudu/util/thread.cc@54 PS1, Line 54: #include "kudu/util/kernel_stack_watchdog.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8256/1/src/kudu/util/thread.cc@112 PS1, Line 112: Number of ms to sleep when starting a new thread > add a blurb about this being test only? Done http://gerrit.cloudera.org:8080/#/c/8256/1/src/kudu/util/threadpool.h File src/kudu/util/threadpool.h: http://gerrit.cloudera.org:8080/#/c/8256/1/src/kudu/util/threadpool.h@230 PS1, Line 230: int num_threads() const { > docs Done -- To view, visit http://gerrit.cloudera.org:8080/8256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If91cb032db25ed539ec8a952f302cf4501b3c240 Gerrit-Change-Number: 8256 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 11 Oct 2017 06:53:56 +0000 Gerrit-HasComments: Yes
