Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 )
Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h@285 PS11, Line 285: a transacti > Nit: "a transaction" Done http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h@287 PS11, Line 287: thr > Nit: Don't need "the". Done http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h@292 PS11, Line 292: // Add a block to the creation transaction. > You should still have a brief doc for Add, it just doesn't have to talk abo Done -- To view, visit http://gerrit.cloudera.org:8080/8144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c7d437061f98ad27b9aecda5fa89e909fb2ec6 Gerrit-Change-Number: 8144 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 11 Oct 2017 22:57:21 +0000 Gerrit-HasComments: Yes
