Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 )
Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h@285 PS11, Line 285: transaction Nit: "a transaction" Below too. http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h@287 PS11, Line 287: the Nit: Don't need "the". Below too. http://gerrit.cloudera.org:8080/#/c/8144/11/src/kudu/fs/block_manager.h@292 PS11, Line 292: virtual void AddCreatedBlock(std::unique_ptr<WritableBlock> block) = 0; You should still have a brief doc for Add, it just doesn't have to talk about thread safety. Below too. -- To view, visit http://gerrit.cloudera.org:8080/8144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c7d437061f98ad27b9aecda5fa89e909fb2ec6 Gerrit-Change-Number: 8144 Gerrit-PatchSet: 11 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 11 Oct 2017 18:35:01 +0000 Gerrit-HasComments: Yes
