Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 )
Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8144/8/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8144/8/src/kudu/fs/log_block_manager.cc@1152 PS8, Line 1152: std::unique_ptr<WritableBlock> block) { > The issue with the third is DoCloseBlocks() takes 'const vector<LogWritable I understand what you mean now; thanks for the explanation. Yes, the old approach makes more sense. -- To view, visit http://gerrit.cloudera.org:8080/8144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c7d437061f98ad27b9aecda5fa89e909fb2ec6 Gerrit-Change-Number: 8144 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 10 Oct 2017 23:43:45 +0000 Gerrit-HasComments: Yes
