Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 )
Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8144/6/src/kudu/fs/file_block_manager.cc@856 PS6, Line 856: return std::make_shared<internal::FileBlockDeletionTransaction>(this); > Why did you remove these checks? Yeah, I removed these checks for the reason you figure out at in the following patch. :) I will add it back and make changes in the following patches based on your recommendations accordingly. http://gerrit.cloudera.org:8080/#/c/8144/8/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/8144/8/src/kudu/fs/log_block_manager.cc@1152 PS8, Line 1152: created_blocks_.emplace_back(unique_ptr<LogWritableBlock>(lwb)); > Now that created_blocks() is gone, you could store these directly into some Done, but I kept "std::vector<std::unique_ptr<LogWritableBlock>> created_blocks_;", because using 'unordered_map<LogBlockContainer*, vector<unique_ptr<LogWritableBlock>>> created_block_map_;' only means more transformation for L1160, L1162 and L1176. Please let me know if you think this makes sense. -- To view, visit http://gerrit.cloudera.org:8080/8144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60c7d437061f98ad27b9aecda5fa89e909fb2ec6 Gerrit-Change-Number: 8144 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 10 Oct 2017 22:41:47 +0000 Gerrit-HasComments: Yes
