Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 )
Change subject: [java client] imporve AsyncKuduScanner logging ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8382/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8382/1//COMMIT_MSG@7 PS1, Line 7: imporve improve http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@509 PS1, Line 509: ScannerExpiredException I think we really need a better name for this exception, it doesn't convey at all that this only happens when you have a fault tolerant scanner and it makes the above comment necessary. http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@515 PS1, Line 515: message += " with lastPrimaryKey: " + Bytes.pretty(lastPrimaryKey); Since you're adding the lastPrimariKey to toString() and that we'd also want the scanner id on this line, skip this and just add AsyncKuduScanner.this like below? http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@888 PS1, Line 888: scannerId = id; Isn't that overriding what we do on line 403? Instead on line 897 I'd just print the response.toString + " for scanner + " + AsyncKuduScanner.this or something like that. http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@904 PS1, Line 904: tabletSlice mind also removing "Slice" here? It's an old artefact. -- To view, visit http://gerrit.cloudera.org:8080/8382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ffcd01e7f99f3090fa118092fc303e06fb92dc Gerrit-Change-Number: 8382 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2017 21:49:55 +0000 Gerrit-HasComments: Yes
