Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 )
Change subject: [java client] imporve AsyncKuduScanner logging ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@520 PS1, Line 520: String message = old_tablet + " pretends to not know " + AsyncKuduScanner.this; : LOG.warn(message, e); nit here and above: consider using 'formatted' version like LOG.warn("{} pretends to not know {}", old_tablet, AsyncKuduScanner.this, e); http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: http://gerrit.cloudera.org:8080/#/c/8382/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java@400 PS1, Line 400: } else { : reportError("RowCount unexpectedly decreased from " + lastRowCount + "to " + rowCount, : null); readability nit: could you remove 'else' here? -- To view, visit http://gerrit.cloudera.org:8080/8382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ffcd01e7f99f3090fa118092fc303e06fb92dc Gerrit-Change-Number: 8382 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 25 Oct 2017 21:59:30 +0000 Gerrit-HasComments: Yes
