Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8586 )
Change subject: WIP [client] expose non-voter replicas for kudu CLI tool ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/client/meta_cache.h@372 PS1, Line 372: > perhaps make this an enum? SHOW_NON_VOTERS / HIDE_NON_VOTERS Done http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/client/meta_cache.cc@612 PS1, Line 612: LookupRpc::LookupRpc(scoped_refptr<MetaCache> meta_cache, > warning: pass by value and use std::move [modernize-pass-by-value] Done http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/ksck.h@161 PS1, Line 161: void set_replicas(std::vector<std::shared_ptr<KsckTabletReplica>> replicas) { > warning: non-const reference parameter 'replicas', make it const or use a p Done http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/ksck_remote.cc@318 PS1, Line 318: show_non_voters_ > might be a little friendlier to make this a setter method The usage pattern for this and rest of the fields is like in a 'private' struct. I was thinking of using getter/setter here, but it would look just for one field. http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/tool_action_table.cc@30 PS1, Line 30: #include "kudu/client/client_builder-internal.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/tool_action_table.cc@64 PS1, Line 64: show_non_voters_ > it would be less hacky to use a setter on Data for this So far all fields of KuduClientBuilder::Data are public, so it's more a struct, actually. I followed the already existing pattern here. I don't think it's worth changing it for just this particular field. http://gerrit.cloudera.org:8080/#/c/8586/1/src/kudu/tools/tool_action_table.cc@87 PS1, Line 87: is_voter_ > mind putting a getter on this? Here is the same story with KuduReplica::Data: it's more like a struct with constant public fields. I'm not sure it's worth exposing this particular one via a getter. -- To view, visit http://gerrit.cloudera.org:8080/8586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20 Gerrit-Change-Number: 8586 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2017 22:01:53 +0000 Gerrit-HasComments: Yes
