Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: tablet: introduce closed mvcc and stopped tablets ...................................................................... Patch Set 34: (3 comments) http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/integration-tests/stop_tablet-itest.cc File src/kudu/integration-tests/stop_tablet-itest.cc: http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/integration-tests/stop_tablet-itest.cc@137 PS33, Line 137: // Ensure that stopping a tablet will not prevent scans from completing. > We don't need to be guaranteed that the specific replica that has been stop Why use multiple replicas if we want to test that? http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/integration-tests/stop_tablet-itest.cc@200 PS33, Line 200: a new leader will not be elected > I've looped this a couple thousand times with some stress in TSAN and only Well written tests don't fail on stressed TSAN. Do those "normal" errors include this test? http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/rowset_metadata.h File src/kudu/tablet/rowset_metadata.h: http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/rowset_metadata.h@85 PS32, Line 85: Status Flush() const; > Hrm, sorry for the distraction, I was confused about why it wasn't, since i I'd argue we shouldn't do this, since it's basically a c++ bug that this even works. We're "transitively" mutating something, even if it's not the first-hop member of this method, which happens to be a shared_ptr. -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 34 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 08:15:33 +0000 Gerrit-HasComments: Yes
