Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: tablet: introduce closed mvcc and stopped tablets ...................................................................... Patch Set 34: (2 comments) http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/tablet.h@371 PS32, Line 371: col_ids > This was to appease tidybot, which I suppose isn't all too important; sorry gotcha http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/tablet/tablet.cc@952 PS33, Line 952: } : return s; : : case RowOperationsPB::UPDATE: : case RowOperationsPB::DELETE: : s = MutateRowUnlocked(tx_state, row_op, stats); : if (s.IsNotFound()) { : return Status::OK(); : } : return s; : : default: : LOG_WITH_ > Hrm, somewhat, somewhat not. A part of this patch is about handling errors Would you mind splitting these changes into their own patch? They already had ignore_result() so they couldn't fail. -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 34 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 08:24:23 +0000 Gerrit-HasComments: Yes
