Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: tablet: introduce closed mvcc and stopped tablets ...................................................................... Patch Set 35: (4 comments) http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/integration-tests/stop_tablet-itest.cc File src/kudu/integration-tests/stop_tablet-itest.cc: http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/integration-tests/stop_tablet-itest.cc@137 PS33, Line 137: // Ensure that stopping a tablet will not prevent scans from completing. > Why use multiple replicas if we want to test that? 1/3 replicas stopping shouldn't affect fault-tolerant scans but 1/1 will (the TestWorkload wouldn't be able to open a scanner and the test would crash). Added a comment. http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/integration-tests/stop_tablet-itest.cc@200 PS33, Line 200: > Well written tests don't fail on stressed TSAN. Do those "normal" errors in Oh hrm, it seems I had the wrong idea of stressed tsan tests and that these were due to the bugs todd fixed. Regardless, there were no errors due to a failure in this test. With Todd's patch, this gets through 1000/1000 with --cpu_stress_threads=8. http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/rowset_metadata.h File src/kudu/tablet/rowset_metadata.h: http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/rowset_metadata.h@85 PS32, Line 85: Status Flush(); > I'd argue we shouldn't do this, since it's basically a c++ bug that this ev Makes sense, done http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/7439/33/src/kudu/tablet/tablet.cc@952 PS33, Line 952: case RowOperationsPB::UPDATE: : case RowOperationsPB::DELETE: : ignore_result(MutateRowUnlocked(tx_state, row_op, stats)); : return Status::OK(); : : default: : LOG_WITH_PREFIX(FATAL) << RowOperationsPB::Type_Name(row_op->decoded_op.type); : } : return Status::OK(); : } : : void Tablet::ModifyRowSetTree(const RowSetTree& old_tree, : > Would you mind splitting these changes into their own patch? They already h Done -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 35 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 09:24:26 +0000 Gerrit-HasComments: Yes
