Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: tablet: introduce closed mvcc and stopped tablets ...................................................................... Patch Set 36: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/36/src/kudu/integration-tests/stop_tablet-itest.cc File src/kudu/integration-tests/stop_tablet-itest.cc: http://gerrit.cloudera.org:8080/#/c/7439/36/src/kudu/integration-tests/stop_tablet-itest.cc@138 PS36, Line 138: TEST_P(StopTabletITest, TestStoppedTabletsScansGetRedirected) { It seems like this works but I'm worried that if someone changes the read thread to respect timeouts_allowed later than we will lose coverage. Do you mind adding a little test that checks that with a single replica, scans fail after stopping the tablet? -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 36 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 19:38:34 +0000 Gerrit-HasComments: Yes
