Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8627

to review the following change.


Change subject: schema: fast-path for Schema::KeyEquals
......................................................................

schema: fast-path for Schema::KeyEquals

If two schemas are the same object, then KeyEquals can be fast-pathed.

This hasn't been a hot path in release builds, but I noticed a lot of wasted
CPU in a debug build evaluating Schema::KeyEquals, and my suspicion is that in
a great number of cases the objects are identical. Even in release builds, may
as well avoid the unnecessary cycles.

Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
---
M src/kudu/common/schema.h
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8627/1
--
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>

Reply via email to