Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8627 )
Change subject: schema: fast-path for Schema::KeyEquals ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8627/1/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/8627/1/src/kudu/common/schema.h@706 PS1, Line 706: if (this == &other) return true; > Does it make sense to add the same for ColumnSchema::{Equals,EqualsType,Equ Done -- To view, visit http://gerrit.cloudera.org:8080/8627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae Gerrit-Change-Number: 8627 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2017 00:30:03 +0000 Gerrit-HasComments: Yes
