Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8627 )
Change subject: schema: fast-path for Schema::KeyEquals, etc. ...................................................................... schema: fast-path for Schema::KeyEquals, etc. If two schemas are the same object, then KeyEquals can be fast-pathed. The same goes for various ColumnSchema equality checks. This hasn't been a hot path in release builds, but I noticed a lot of wasted CPU in a debug build evaluating Schema::KeyEquals, and my suspicion is that in a great number of cases the objects are identical. Even in release builds, may as well avoid the unnecessary cycles. Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae Reviewed-on: http://gerrit.cloudera.org:8080/8627 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/common/schema.h 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae Gerrit-Change-Number: 8627 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
