Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 )
Change subject: WIP KUDU-1097 (patch 2&4): added 3-4-3 behavior for catalog manager ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc@414 PS6, Line 414: peer.has_attrs() && > no need to check has_attrs() why not? http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc@432 PS6, Line 432: return replication_factor > (num_voters_total - num_voters_need_replacement) + > are you counting non-voters with promote = true as potential voters for the yes, i do -- see at line 420 -- To view, visit http://gerrit.cloudera.org:8080/8619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0469ac641bf7a03dbef01eaa3f1b58a5bf5d27 Gerrit-Change-Number: 8619 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 23 Nov 2017 03:24:21 +0000 Gerrit-HasComments: Yes
