Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 )
Change subject: KUDU-1097: 3-4-3 behavior for catalog manager ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc@411 PS6, Line 411: if ((peer.has_health_report() && : peer.health_report().has_overall_health() && : peer.health_report().overall_health() > I don't think so. What if the health_report() is not present? SIGSEGV, eh Ah, I take this back. Yes, it's safe to do as you mentioned. Sometimes I confuse protobuf with packetbrain -- in-house implementation of protobuf-like framework I used with one of my former employers. http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc@414 PS6, Line 414: peer.has_attrs() && > why not? sure. -- To view, visit http://gerrit.cloudera.org:8080/8619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0469ac641bf7a03dbef01eaa3f1b58a5bf5d27 Gerrit-Change-Number: 8619 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 24 Nov 2017 04:50:59 +0000 Gerrit-HasComments: Yes
