Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 )
Change subject: KUDU-1097: 3-4-3 behavior for catalog manager ...................................................................... Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/consensus/quorum_util.cc@432 PS6, Line 432: num_non_voters_to_promote; > That invariant needs an update: it does not include replicas marked for rep Yes, good point, we should update that in the doc http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/master/catalog_manager.cc@3512 PS6, Line 3512: master_, tablet, cstate, RaftPeerPB::VOTER, &rng_)); > What is the crucial difference here? If it's over-replicated, then NeedNon I was thinking about the case where we had just promoted a non-voter to voter and then saw another failure while we had > replication_factor voters, but right now we're very conservative about how we evict so I don't think it's something we need to worry about yet. -- To view, visit http://gerrit.cloudera.org:8080/8619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0469ac641bf7a03dbef01eaa3f1b58a5bf5d27 Gerrit-Change-Number: 8619 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 27 Nov 2017 04:04:04 +0000 Gerrit-HasComments: Yes
