Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8619 )
Change subject: KUDU-1097: 3-4-3 behavior for catalog manager ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8619/6/src/kudu/master/catalog_manager.cc@3512 PS6, Line 3512: ReadyToEvictReplica(config, replication_factor, &to_evict)) { > I was thinking about the case where we had just promoted a non-voter to vot Yep -- both adding new non-voter and evicting are conservative now, so we avoid adding too many replicas as a result. Please let me know about a scenario where you suspect the code of IsUnderReplicated() or CanEvictReplica() does not behave as expected -- I'll add a testcase into the quorum_util-test.cc -- To view, visit http://gerrit.cloudera.org:8080/8619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f0469ac641bf7a03dbef01eaa3f1b58a5bf5d27 Gerrit-Change-Number: 8619 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 27 Nov 2017 05:35:33 +0000 Gerrit-HasComments: Yes
