Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8859 )
Change subject: KUDU-2115: remove unnecessary compaction selection check ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8859/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8859/2//COMMIT_MSG@23 PS2, Line 23: as the correct set of rowsets : would be returned by PickRowSetsToCompact() > What is 'the correct set of rowsets'? Does this mean returning a rowset wh Ah, correct here means that rowsets that no longer exist (eg that have already been compacted) will not be returned. -- To view, visit http://gerrit.cloudera.org:8080/8859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236 Gerrit-Change-Number: 8859 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 19:30:41 +0000 Gerrit-HasComments: Yes
