Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8859 )
Change subject: KUDU-2115: avoid compacting already-compacted rowsets ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/diskrowset.h File src/kudu/tablet/diskrowset.h: http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/diskrowset.h@435 PS4, Line 435: virtual Status DebugDump(std::vector<std::string> *lines = NULL) override; > warning: default arguments on virtual or override methods are prohibited [g Done http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/diskrowset.h@478 PS4, Line 478: std::atomic<bool> has_been_compacted_; > add doc Done http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/memrowset.h@293 PS4, Line 293: // TODO: unit test me > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/memrowset.h@350 PS4, Line 350: virtual Status DebugDump(std::vector<std::string> *lines = NULL) override; > warning: default arguments on virtual or override methods are prohibited [g Done http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/memrowset.h@376 PS4, Line 376: double DeltaStoresCompactionPerfImprovementScore(DeltaCompactionType type) const override { > warning: parameter 'type' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/memrowset.h@441 PS4, Line 441: std::atomic<bool> has_been_compacted_; > doc Done http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/rowset.h File src/kudu/tablet/rowset.h: http://gerrit.cloudera.org:8080/#/c/8859/4/src/kudu/tablet/rowset.h@237 PS4, Line 237: rowset > i think better to be explicit and say that it has been removed from the Row Done -- To view, visit http://gerrit.cloudera.org:8080/8859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236 Gerrit-Change-Number: 8859 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2018 23:11:10 +0000 Gerrit-HasComments: Yes
