Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8859 )
Change subject: KUDU-2115: remove unnecessary compaction selection check ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8859/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/8859/3/src/kudu/tablet/tablet.cc@a1341 PS3, Line 1341: Maybe, at least return an error in this case to preserve the original behavior. I'm not sure it's safe otherwise -- I'll need to get better understanding of that mechanics to be sure. As of now, I'm under impression that this check is to prevent compaction of the same rowset concurrently by multiple actors. I might be wrong, but this change does not look safe to me, maybe just because of my limited knowledge of the internals. -- To view, visit http://gerrit.cloudera.org:8080/8859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236 Gerrit-Change-Number: 8859 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 19:41:03 +0000 Gerrit-HasComments: Yes
