Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8859 )
Change subject: KUDU-2115: remove unnecessary compaction selection check ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8859/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/8859/3/src/kudu/tablet/tablet.cc@a1341 PS3, Line 1341: > Maybe, at least return an error in this case to preserve the original behav I don't think we needed to abort these compactions in the first place. The output parameter `picked` would correctly return only the selected rowsets that still exist while holding the component_lock_. Although it's a good question, why was this here in the first place? -- To view, visit http://gerrit.cloudera.org:8080/8859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dab330d61facb18717f6faf179f9b94a9e55236 Gerrit-Change-Number: 8859 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Dec 2017 20:05:31 +0000 Gerrit-HasComments: Yes
