Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 )
Change subject: java: improve error messages when tokens are not used ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@337 PS1, Line 337: chosenAuthnType = chooseAuthenticationType(response); > Isn't there only the choice of sasl and token? where are you suggesting we Yes, I think it makes sense to expose that information as well in case of negotiation error. It could be useful if there is some bug on the server side so the server doesn't accept token even if the client is ready to send it in. http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@57 PS1, Line 57: Assert.assertThat(e.getMessage(), CoreMatchers.containsString( > I wasn't sure how to engineer those situations without having to do a bunch Well, by my understanding this particular place is just for the specific case. Not sure we want to verify other cases right here. -- To view, visit http://gerrit.cloudera.org:8080/9070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5160a79e973c411c16a784dc105444f5dd2a6f Gerrit-Change-Number: 9070 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2018 01:24:15 +0000 Gerrit-HasComments: Yes
