Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 )
Change subject: java: improve error messages when tokens are not used ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@337 PS1, Line 337: chosenAuthnType = chooseAuthenticationType(response); > Yes, I think it makes sense to expose that information as well in case of in the case that the server doesn't accept token, we'll end up in the SASL path down below and hit the error messages that I've added in this patch. ie these error messages I've added are _only_ in the case that it's SASL, so adding it would always result in saying "SASL was chosen". -- To view, visit http://gerrit.cloudera.org:8080/9070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5160a79e973c411c16a784dc105444f5dd2a6f Gerrit-Change-Number: 9070 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 19 Jan 2018 01:42:08 +0000 Gerrit-HasComments: Yes
