Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 )
Change subject: java: improve error messages when tokens are not used ...................................................................... Patch Set 1: (1 comment) > > Would be great to get this in for 1.7. > > Overall, the change looks good to me. Can it make to 1.7? There are some nits left (those that Dan pointed at), but otherwise I think it looks good. http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@337 PS1, Line 337: chosenAuthnType = chooseAuthenticationType(response); > in the case that the server doesn't accept token, we'll end up in the SASL sgtm -- To view, visit http://gerrit.cloudera.org:8080/9070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5160a79e973c411c16a784dc105444f5dd2a6f Gerrit-Change-Number: 9070 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 23 Feb 2018 19:15:02 +0000 Gerrit-HasComments: Yes