Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9070 )
Change subject: java: improve error messages when tokens are not used ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@135 PS1, Line 135: was s/was/is to keep the tense consistent http://gerrit.cloudera.org:8080/#/c/9070/1/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@439 PS1, Line 439: message = "server requires SASL authentication, but " + I don't think adding SASL makes it more correct here, the server may also accept token or cert authn. -- To view, visit http://gerrit.cloudera.org:8080/9070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f5160a79e973c411c16a784dc105444f5dd2a6f Gerrit-Change-Number: 9070 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 19 Jan 2018 01:39:01 +0000 Gerrit-HasComments: Yes