Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9237 )
Change subject: Add previous / current thread to collision warner ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9237/1/src/kudu/gutil/threading/thread_collision_warner.h File src/kudu/gutil/threading/thread_collision_warner.h: http://gerrit.cloudera.org:8080/#/c/9237/1/src/kudu/gutil/threading/thread_collision_warner.h@132 PS1, Line 132: : // The class ThreadCollisionWarner uses an Asserter to notify the collision : // AsserterBase is the interfaces and DCheckAsserter is the default asserter : // used. During the unit tests is used another class that doesn't "D > I'd rather not change that because it's a copy / paste import from Chromium Ah, that makes sense. SGTM. -- To view, visit http://gerrit.cloudera.org:8080/9237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7 Gerrit-Change-Number: 9237 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 07 Feb 2018 20:03:19 +0000 Gerrit-HasComments: Yes
