Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9237 )
Change subject: Add previous / current thread to collision warner ...................................................................... Add previous / current thread to collision warner The failure message is now more useful and looks like the following: F0206 20:31:24.554322 30972 thread_collision_warner.cc:23] Thread Collision! Previous thread id: 30962, current thread id: 30972 I found this necessary when debugging a particular issue since by the time the SIGABRT triggered in GDB the previous thread had already exited the critical section (perhaps while printing the fatal log message). Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7 Reviewed-on: http://gerrit.cloudera.org:8080/9237 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/gutil/threading/thread_collision_warner.cc M src/kudu/gutil/threading/thread_collision_warner.h 2 files changed, 18 insertions(+), 15 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I038bad901b5235725084bd8671ef4b02ec22c0a7 Gerrit-Change-Number: 9237 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
