Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9489 )
Change subject: KUDU-2230: java: sync client exception stack traces should make sense ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9489/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java: http://gerrit.cloudera.org:8080/#/c/9489/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduException.java@92 PS1, Line 92: StackTraceElement[] stack = new Exception().getStackTrace(); > Would it make sense to safe the original stack into some member of KuduExce I was thinking about saving the original but I think if we print it out in logs it defeats the purpose of removing confusion here. If we just save it in a member and don't print it anywhere it doesn't have much use... so I elected to just ditch it. One option I considered was to log it at TRACE level or something so that we can get to it if we need to in a debug situation. Do you think that solves the use case you had in mind? -- To view, visit http://gerrit.cloudera.org:8080/9489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I874d47b5239bcc8493c15ef763ecfe0fd878d795 Gerrit-Change-Number: 9489 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 21:34:22 +0000 Gerrit-HasComments: Yes
