Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9643 )
Change subject: java: key ConnectionCache by address, improve stringification ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java: http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java@74 PS1, Line 74: private final HashMultimap<InetSocketAddress, Connection> connectionsByIp = Nit: connectionsByAddress? http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@189 PS1, Line 189: // TODO(todd) this doesn't return a random server, but rather returns Open a newbie jira to track/fix it? http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java: http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java@a59 PS1, Line 59: Was this just unnecessary? -- To view, visit http://gerrit.cloudera.org:8080/9643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431b5b6b8af6b81e6ab494d7f84fa2260bb0f941 Gerrit-Change-Number: 9643 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:00:28 +0000 Gerrit-HasComments: Yes
