Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9643 )
Change subject: java: key ConnectionCache by address, improve stringification ...................................................................... Patch Set 1: > Patch Set 1: > > Is AsyncKuduClient.getFakeMasterUuid() still needed or useful with this patch? Well, our Connection class still uses ServerInfo instead of just an IP address, and ServerInfo requires a UUID. SO, while getFakeMasterUuid() being consistent across usages isn't required for correctness anymore, it's still nice to ensure we have a reasonable log instead of an empty string when we try to log the UUID -- To view, visit http://gerrit.cloudera.org:8080/9643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431b5b6b8af6b81e6ab494d7f84fa2260bb0f941 Gerrit-Change-Number: 9643 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:19:28 +0000 Gerrit-HasComments: No
