Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9643 )
Change subject: java: key ConnectionCache by address, improve stringification ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java: http://gerrit.cloudera.org:8080/#/c/9643/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java@a59 PS1, Line 59: > Was this just unnecessary? it might have been necessarily previously to ensure that it made separate new proxies because we didn't properly share proxies between the 'ConnectToCluster' and the later usage? Not sure, but figured I'd just clean up the redundant unused calls. here. -- To view, visit http://gerrit.cloudera.org:8080/9643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431b5b6b8af6b81e6ab494d7f84fa2260bb0f941 Gerrit-Change-Number: 9643 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 00:18:19 +0000 Gerrit-HasComments: Yes
